• This project
    • Loading...
  • Sign in

Marta Miranda / boletin_api

Logo codes
Go to a project
Toggle navigation
  • Projects
  • Groups
  • Snippets
  • Help
Toggle navigation pinning
  • Project
  • Activity
  • Repository
  • Pipelines
  • Graphs
  • Issues 0
  • Merge Requests 0
  • Wiki
  • Network
  • Create a new issue
  • Builds
  • Commits
Merged
Merge Request !69 opened 2023-10-06 10:24:52 UTC by Enzo Yair@Ecardenez

revisar monto descuento y filtros

Edited 2023-10-09 13:57:29 UTC
Request to merge feature/#75_revisar_monto_descuento into develop
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feature/#75_revisar_monto_descuento origin/feature/#75_revisar_monto_descuento

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout develop
git merge --no-ff feature/#75_revisar_monto_descuento

Step 4. Push the result of the merge to GitLab

git push origin develop

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines

Merged by Martín Miranda 2023-10-09 13:57:29 UTC

The changes were merged into develop. The source branch has been removed.

  • Discussion 2
  • Commits 2
  • Changes 5
  • Enzo Yair
    @Ecardenez 2023-10-06 13:21:47 UTC

    Added 1 commit:

    • 421b211e - correcion de palabra en la columna estado
  • Avatar
    Martín Miranda
    @debianitram started a discussion on the diff 2023-10-06 13:51:07 UTC
    Toggle discussion
    project/apps/edicto/precio.py
     
    if descuento:
    resultado = (50 * subtotal) / 100
    • Martín Miranda
      @debianitram commented 2023-10-06 13:51:07 UTC
      Developer

      Esto está bien? porque si tiene descuento, el resultado sería igual que el monto_descuento, por lo tanto parecería que se cancela.

    • Enzo Yair
      @Ecardenez commented 2023-10-06 14:18:51 UTC
      Master

      eh, si. enrealidad lo que busco es colocar el valor en 0 cuando no aplique el descuento. La otra forma era ponerle un operador ternario cuando estoy almacenando el valor, en la columna de monto_descuento.

      Edited 2023-10-06 14:20:21 UTC
  • Martín Miranda
    @debianitram 2023-10-09 13:57:29 UTC

    Status changed to merged

  • Martín Miranda
    @debianitram 2023-10-09 13:57:29 UTC

    mentioned in commit 97b74a83

  • Please register or login to post a comment
Enzo Yair
Assignee
Enzo Yair @Ecardenez
Assign to
None
Milestone
None
Assign milestone
2
2 participants
Reference: mvmiranda/boletin_api!69
×

Revert this merge request

Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Cancel
A new branch will be created in your fork and a new merge request will be started.