• This project
    • Loading...
  • Sign in

Marta Miranda / boletin_api

Logo codes
Go to a project
Toggle navigation
  • Projects
  • Groups
  • Snippets
  • Help
Toggle navigation pinning
  • Project
  • Activity
  • Repository
  • Pipelines
  • Graphs
  • Issues 0
  • Merge Requests 0
  • Wiki
  • Network
  • Create a new issue
  • Builds
  • Commits
Closed
Merge Request !49 opened 2023-09-15 14:55:32 UTC by Enzo Yair@Ecardenez

Fix/fecha modificacion

Edited 2023-09-19 13:08:07 UTC
Request to merge fix/fecha_modificacion into develop
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/fecha_modificacion origin/fix/fecha_modificacion

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout develop
git merge --no-ff fix/fecha_modificacion

Step 4. Push the result of the merge to GitLab

git push origin develop

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines

Closed by Enzo Yair 2023-09-19 13:08:05 UTC

The changes were not merged into develop.

  • Discussion 3
  • Commits 21
  • Changes 5
  • Enzo Yair
    @Ecardenez 2023-09-15 21:06:40 UTC

    Added 1 commit:

    • 25250c9e - actualizacion
  • Enzo Yair
    @Ecardenez 2023-09-15 22:26:16 UTC

    Added 1 commit:

    • effecce8 - eliminacion de timezone.now en metodo patch
  • Enzo Yair
    @Ecardenez 2023-09-18 11:23:01 UTC

    Added 3 commits:

    • effecce8...38f0f2e5 - 2 commits from branch develop
    • ab1b7a64 - Merge branch 'develop' of http://gitlab.catamarca.gob.ar/mvmiranda/boletin_api i…
  • Avatar
    Martín Miranda
    @debianitram started a discussion on the diff 2023-09-18 13:43:59 UTC
    Toggle discussion
    project/apps/edicto/api.py
     
    class EdictoViewSet(mixins.CreateModelMixin,
    • Martín Miranda
      @debianitram commented 2023-09-18 13:43:59 UTC
      Developer

      Tienes que dejar UpdateModelMixin

  • Avatar
    Martín Miranda
    @debianitram started a discussion on an outdated diff 2023-09-18 13:45:03 UTC
    Toggle discussion
    project/apps/edicto/serializer.py
    'fecha_publicacion',
    'fecha_modificacion'
     
    )
    extra_kwargs = {
    'archivo': {'read_only': True},
    'cantidad_palabras': {'read_only': True}
    }
     
    read_only_fields = ('usuario', 'usuario_movimiento',
    'fecha_publicacion', 'cantidad_palabras',
    'fecha_creacion',
    'fecha_modificacion',
    )
     
    def to_representation(self, instance):
    • Martín Miranda
      @debianitram commented 2023-09-18 13:45:03 UTC
      Developer

      Este método es necesario?

    • Martín Miranda
      @debianitram commented 2023-09-18 13:50:51 UTC
      Developer

      Fijate que si aplican bien las propiedades de los DateTimeField, para lo que entiendo acá no será necesario reescribir éste método:

      • https://docs.djangoproject.com/en/4.2/ref/models/fields/#datefield

      • https://www.django-rest-framework.org/api-guide/fields/#datetimefield-format-strings

  • Enzo Yair
    @Ecardenez 2023-09-18 15:00:47 UTC

    Added 1 commit:

    • f0909e95 - delete metodo to_representation
  • Enzo Yair
    @Ecardenez 2023-09-18 15:07:26 UTC

    Added 1 commit:

    • 6525067b - cambios en el migrate
  • Enzo Yair
    @Ecardenez 2023-09-18 20:26:28 UTC

    Added 1 commit:

    • f3c27f6c - eliminacion de metodos en api
  • Enzo Yair
    @Ecardenez 2023-09-18 20:37:20 UTC

    Added 1 commit:

    • 8a8bf143 - validacion en metodo post para usuario
  • Enzo Yair
    @Ecardenez 2023-09-19 10:09:37 UTC

    Added 1 commit:

    • 6fc2d350 - cambio de request.user
  • Enzo Yair
    @Ecardenez 2023-09-19 10:17:19 UTC

    Added 1 commit:

    • a89c6edc - se elimina validaciones de usario
  • Enzo Yair
    @Ecardenez 2023-09-19 11:47:32 UTC

    Added 1 commit:

    • ce5a86b2 - validacion de usuario
  • Enzo Yair
    @Ecardenez 2023-09-19 13:08:07 UTC

    Status changed to closed

  • Please register or login to post a comment
Enzo Yair
Assignee
Enzo Yair @Ecardenez
Assign to
None
Milestone
None
Assign milestone
1
1 participant
Reference: mvmiranda/boletin_api!49