• This project
    • Loading...
  • Sign in

Marta Miranda / boletin_api

Logo codes
Go to a project
Toggle navigation
  • Projects
  • Groups
  • Snippets
  • Help
Toggle navigation pinning
  • Project
  • Activity
  • Repository
  • Pipelines
  • Graphs
  • Issues 0
  • Merge Requests 0
  • Wiki
  • Network
  • Create a new issue
  • Builds
  • Commits
Merged
Merge Request !15 opened 2023-07-26 12:50:10 UTC by Enzo Yair@Ecardenez

Feature/#18 corregir models y serializer

Edited 2023-07-28 18:04:28 UTC
Request to merge feature/#18_corregir_models_y_serializer into develop
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feature/#18_corregir_models_y_serializer origin/feature/#18_corregir_models_y_serializer

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout develop
git merge --no-ff feature/#18_corregir_models_y_serializer

Step 4. Push the result of the merge to GitLab

git push origin develop

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines

Merged by Martín Miranda 2023-07-28 18:04:28 UTC

The changes were merged into develop. The source branch has been removed.

  • Discussion 2
  • Commits 3
  • Changes 13
  • Avatar
    Martín Miranda
    @debianitram started a discussion on the diff 2023-07-26 13:12:09 UTC
    Toggle discussion
    project/apps/edicto/utils.py
     
    def valid_extension(value):
    if (not value.name.endswith('.pdf') and
    • Martín Miranda
      @debianitram commented 2023-07-26 13:12:09 UTC
      Developer

      Por favor, genere una constante EXTENSIONES_VALIDAS que sea una lista de strings que contenga las extensiones, luego podría extraer la extensión con la siguiente expresión:

      filename, extension = value.name.split(".")

      y finalmente realizar la condición:

      if extension not in EXTENSIONES_VALIDAS:
          raise ...
      Edited 2023-07-26 13:13:07 UTC
    • Enzo Yair
      @Ecardenez commented 2023-07-28 15:15:54 UTC
      Master

      Ya fue reemplazada la función por la constante

  • Enzo Yair
    @Ecardenez 2023-07-28 15:08:39 UTC

    Added 1 commit:

    • bcdde74b - reformateo_de_funcion_por_constante
  • Martín Miranda
    @debianitram 2023-07-28 18:04:28 UTC

    Status changed to merged

  • Martín Miranda
    @debianitram 2023-07-28 18:04:28 UTC

    mentioned in commit 827b1243

  • Please register or login to post a comment
Enzo Yair
Assignee
Enzo Yair @Ecardenez
Assign to
None
Milestone
None
Assign milestone
2
2 participants
Reference: mvmiranda/boletin_api!15
×

Revert this merge request

Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Cancel
A new branch will be created in your fork and a new merge request will be started.